Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace undef constant floats with 0 #328

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

2over12
Copy link
Contributor

@2over12 2over12 commented Jul 6, 2023

NaN would also be kinda viable

@2over12 2over12 requested a review from frabert as a code owner July 6, 2023 12:43
@frabert
Copy link
Collaborator

frabert commented Jul 6, 2023

The patch looks good to me, I'm just confused as to why the CI is not running 🙃

@frabert frabert merged commit f282426 into frabert/pluggable-vars Jul 6, 2023
@frabert frabert deleted the ian/handle-undef-fp-values branch July 6, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants