Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5/? ] - lnwallet: add taproot funding support to the internal wallet flow (reservations) #7344
[5/? ] - lnwallet: add taproot funding support to the internal wallet flow (reservations) #7344
Changes from all commits
b509aa3
83af278
4cd3eec
96c48ba
7225071
88d1384
0832469
b4fa433
2d4df80
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some notes for other reviewers, was wondering if
lc.currentHeight
is always updated to date here sinceNewAnchorResolutions
makes a separate call to db and creates a newLightningWallet
. This is fine as we'd only call it whenStateCommitmentBroadcasted
, which means the db has the latest view of the local commit, and no other goroutines can update it anymore because it's closed.