watchtower+refactor: CommitmentType and JusticeKit interface #7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
added
the
code health
ellemouton
force-pushed
the
towerInterfaces
branch
from
328b828 to
abfb9d6
Compare
ellemouton
force-pushed
the
towerInterfaces
branch
3 times, most recently
from
fc39a66 to
a90576f
Compare
ellemouton
force-pushed
the
towerInterfaces
branch
3 times, most recently
from
7e1acea to
a851935
Compare
ellemouton
force-pushed
the
towerInterfaces
branch
from
a851935 to
34a7293
Compare
ellemouton
force-pushed
the
towerInterfaces
branch
from
34a7293 to
3bbdc28
Compare
guggero
approved these changes
Dec 12, 2023
ellemouton
force-pushed
the
towerInterfaces
branch
from
3bbdc28 to
960471e
Compare
ellemouton
commented
Dec 12, 2023
|
@bitromortac: review reminder |
ellemouton
force-pushed
the
towerInterfaces
branch
from
960471e to
920cdaa
Compare
|
pushed a tiny update here to incorporate this comment from the follow up PR. No logic changes - just changing the JusticeKit API to return types like |
bitromortac
approved these changes
Jan 4, 2024
In this commit a new enum, CommitmentType, is introduced and initially there are 3 CommitmentTypes: Legacy, LegacyTweakless and Anchor. Then, various methods are added to `CommitmentType`. This allows us to remove a bunch of "if-else" chains from the `wtclient` and `lookout` code. This will also make things easier to extend when a new commitment type (like Taproot) is added.
In preparation for the next commit which will introduce the `JusticeKit` interface, here we just move the code related to building the actual justice kit packet into a separate file.
In this commit, we convert the `JusticeKit` struct to an interface. Then, we add two implementations of that interface: 1) The `legacyJusticeKit` which implements all the methods of `JusticeKit` 2) The `anchorJusticKit` which wraps the `legacyJusticeKit` and just re-implements the `ToRemoteOutputSpendInfo` method since.
ellemouton
force-pushed
the
towerInterfaces
branch
from
920cdaa to
4daa0f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a pure refactor of some watchtower code. Currently, the
tower code is littered with many
if isAnchor() {..} else {}blocksand this will become even more hairy once we have to cater for
taproot channels. With that in mind, this PR does a few things so that
adding support for taproot channels can be a relatively small diff:
CommitmentTypeenum is added which will hide some detailsabout the inputs of the justice transaction.
JusticeKitis converted from a struct to an interface with variousmethods on it. Two implementations are added:
legacyJusticeKitandanchorJusticeKitboth of which use the same encoding.This is a pre-requisite for #7733