-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqldb+invoices: turn sqldb into a go module #8603
Conversation
WalkthroughThe recent updates encompass modernizing dependencies and restructuring the invoice management system. The Changes
Recent Review StatusConfiguration used: CodeRabbit UI Files ignored due to path filters (4)
Files selected for processing (7)
Files skipped from review as they are similar to previous changes (6)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
type InvoiceQueries interface { //nolint:interfacebloat | ||
// SQLInvoiceQueries is an interface that defines the set of operations that can | ||
// be executed against the invoice SQL database. | ||
type SQLInvoiceQueries interface { //nolint:interfacebloat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this should instead live in channeldb
?
This way then the invoice
package declares the interface, but doesn't necessarily implement it itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My simple reasoning for also moving the interface here was that the SQL InvoiceDB implementation depends on this interface hence it's maybe best kept along with the implementation itself. If we move though perhaps sqldb
might be a better choice?
f9925cb
to
7a487b0
Compare
Is there a reason, why this has to be a versioned package? The PR description does not make that clear. Thanks. |
In order to reuse the same retry code in both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
7a487b0
to
536b23c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
536b23c
to
c804894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦚
As a preliminary change before we unify the transaction retry between
sqldb
andkvdb
we extract the SQL invoice store implementation into theinvoices
package and makesqldb
a versioned package.