-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] Loaders should not throw http exceptions. #373
Comments
@makasim, I partially disagree with this. If source image can not be found on the server client should receive 404 otherwise it will be a bit weird. I can agree that if you call cache manager in controller like |
@Me1ifaro loaders should not throw http exception but something like |
@makasim, already implemented in that way. If |
I dont like it either but it at least consistent with other exception we have already. |
@Me1ifaro could you open a PR? |
It's already opened, see #403. Actually now Travis build fails, but it is not caused by my changes. There is some madness in symfony dev-master |
yeah, I see it too, I am going to use only symfony 2.3 version on travis. I'll fix it today |
…xceptions Fixes #373. Replace NotFoundHttpException with SourceNotFoundException
No description provided.
The text was updated successfully, but these errors were encountered: