Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unit tests #650

Closed
lsmith77 opened this issue Oct 26, 2015 · 1 comment
Closed

fix unit tests #650

lsmith77 opened this issue Oct 26, 2015 · 1 comment

Comments

@lsmith77
Copy link
Contributor 

There were 2 failures:
1) Liip\ImagineBundle\Tests\Imagine\Cache\Resolver\CacheResolverTest::testRemoveSinglePathCacheOnRemove
Failed asserting that actual size 2 matches expected size 3.
/home/travis/build/liip/LiipImagineBundle/Tests/Imagine/Cache/Resolver/CacheResolverTest.php:140
2) Liip\ImagineBundle\Tests\Imagine\Cache\Resolver\CacheResolverTest::testRemoveAllFilterCacheOnRemove
Failed asserting that actual size 6 matches expected size 7.
/home/travis/build/liip/LiipImagineBundle/Tests/Imagine/Cache/Resolver/CacheResolverTest.php:175

This seems to be a regression of some sort since things are working fine when we test lower dependencies: https://travis-ci.org/liip/liip/LiipImagineBundle/builds/87425790
@lsmith77 lsmith77 added the State: Confirmed This item has been confirmed by maintainers as legitimate. label Oct 26, 2015
@havvg
Copy link
Contributor

havvg commented Oct 27, 2015

The correct link: https://travis-ci.org/liip/LiipImagineBundle/builds/87425790

kamazee added a commit to kamazee/LiipImagineBundle that referenced this issue Oct 30, 2015
@kamazee
Fix broken CacheResolver tests (liip#650)
1926e3a 
Since September'2015 Doctrine doesn't always save namespace version in
the cache itself:
doctrine/cache@ecc4af1

Relying on such kind of implementation detail in tests that is supposed
to check if several keys are saved in cache is kind of pointless, so it
makes sense to ignore cache key that holds namespace version
kamazee added a commit to kamazee/LiipImagineBundle that referenced this issue Oct 30, 2015
@kamazee
Fix broken CacheResolver tests (liip#650)
c0364ed 
Since September'2015 Doctrine doesn't always save namespace version in
the cache itself:
doctrine/cache@ecc4af1

Relying on such kind of implementation detail in tests that is supposed
to check if several keys are saved in cache is kind of pointless, so it
makes sense to ignore cache key that holds namespace version
kamazee added a commit to kamazee/LiipImagineBundle that referenced this issue Oct 30, 2015
@kamazee
Fix broken CacheResolver tests (liip#650)
c97aaa3 
Since September'2015 Doctrine doesn't always save namespace version in
the cache itself:
doctrine/cache@ecc4af1

Relying on such kind of implementation detail in test that is supposed
to check if several keys are saved in cache is kind of pointless, so it
makes sense to ignore cache key that holds namespace version
kamazee added a commit to kamazee/LiipImagineBundle that referenced this issue Oct 30, 2015
@kamazee
Fix broken CacheResolver tests (liip#650)
716bfd4 
Since September'2015 Doctrine doesn't always save namespace version in
the cache itself:
doctrine/cache@ecc4af1

Relying on such kind of implementation detail in a test that is supposed
to check if several keys are saved in cache is kind of pointless, so it
makes sense to ignore cache key that holds namespace version
kamazee added a commit to kamazee/LiipImagineBundle that referenced this issue Oct 30, 2015
@kamazee
Fix broken CacheResolver tests (liip#650)
05a3c89 
Since September'2015 Doctrine doesn't always save namespace version in
the cache itself:
doctrine/cache@ecc4af1

Relying on such kind of implementation detail in a test that is supposed
to check if several keys are saved in a cache is kind of pointless, so it
makes sense to ignore the cache key that holds a namespace version
@kamazee kamazee mentioned this issue Oct 30, 2015
Merged
kamazee added a commit to kamazee/LiipImagineBundle that referenced this issue Oct 30, 2015
@kamazee
Fix broken CacheResolver tests (liip#650)
785a0d1 
Since September'2015 Doctrine doesn't always save namespace version in
the cache itself:
doctrine/cache@ecc4af1

Relying on such kind of implementation detail in a test that is supposed
to check if several keys are saved in a cache is kind of pointless, so it
makes sense to ignore the cache key that holds a namespace version
@lsmith77 lsmith77 removed the State: Confirmed This item has been confirmed by maintainers as legitimate. label Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@havvg @lsmith77