Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale filter not found / incorrect filter config documentation #818

Closed
jazithedev opened this issue Oct 30, 2016 · 4 comments
Closed

Scale filter not found / incorrect filter config documentation #818

jazithedev opened this issue Oct 30, 2016 · 4 comments
Labels
Type: Documentation This item pertains to documentation of this project.

Comments

@jazithedev
Copy link

jazithedev commented Oct 30, 2016

http://symfony.com/doc/master/bundles/LiipImagineBundle/filters/sizing.html#scale

parameters:
    images_quality: 80

liip_imagine:
    resolvers:
        default:
            web_path:
                cache_prefix: images/thumb

    filter_sets:
        cache: ~
        news_image:
            quality: '%images_quality%'
            filters:
                scale: { dim: [ 1000, 666 ] }

AAaaaaaaand it's not working. Returning error:

Could not find filter loader for "scale" filter type

Why documentation is writing about something that is not working???

And, when I'm adding - character before scale: { dim: [ 1000, 666 ] } (based on documentation from Symfony.com), error occurs:

The attribute "name" must be set for path "liip_imagine.filter_sets.news_image.filters".

Where is the most updated documentation for this bundle...?

@robfrawley
Copy link
Collaborator

robfrawley commented Oct 30, 2016

@ktrzos The most updated documentation is the website you linked to, hosted on the official Symfony docs, and automatically re-generated from the ReStructured Text files in this repository at Resources/doc on each push.

As for the scale filter, it was added after the last stable release, so you will need to set you composer version constraint to dev-master or similar if you'd like to use it.

And regarding the configuration formatting issue mentioned, I will look into that further, but it looks like the - was a copy-paste error and should be removed from the examples. I'll confirm such and commit and push the changes shortly. Thanks for the heads-up.

@robfrawley robfrawley added Type: Documentation This item pertains to documentation of this project. State: Confirmed This item has been confirmed by maintainers as legitimate. labels Oct 30, 2016
@robfrawley robfrawley changed the title Could not find filter loader for "scale" filter type Scale filter not found / incorrect filter config documentation Oct 30, 2016
@robfrawley
Copy link
Collaborator

robfrawley commented Oct 30, 2016

@ktrzos Documentation changes have been pushed to address the error you pointed out. It should be available in the generated, online docs shortly; the compilation of them are automatic and quick).

If this and my previous answer resolve your issue, please close this.

@lsmith77 lsmith77 removed the State: Confirmed This item has been confirmed by maintainers as legitimate. label Oct 30, 2016
@robfrawley
Copy link
Collaborator

@ktrzos I accidentally closed this; I generally prefer that the person who opened it closes it as a confirmation that the issue is solved. Please re-open if this is not the case. Thanks!

@jazithedev
Copy link
Author

Not a problem :). It's all ok now... I think :D. Thanks for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation This item pertains to documentation of this project.
Projects
None yet
Development

No branches or pull requests

3 participants