Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UPGRADE.md with a bc break notice #1235

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Update UPGRADE.md with a bc break notice #1235

merged 1 commit into from
Oct 7, 2019

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Oct 6, 2019

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

As @robfrawley pointed out, when I passed the php-cs-fixer, an internal class was changed to final, this could be a bc break, this PR is about updating the UPGRADE.md file, noticing that.

dbu
dbu approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it is an internal class already, i think the warning is good enough, no need to revert the final

@dbu dbu merged commit 074da1a into liip:master Oct 7, 2019
@dbu
Copy link
Member

dbu commented Oct 7, 2019

thank you!

@franmomu franmomu deleted the patch-4 branch October 7, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franmomu @dbu