Symfony5

[michellesanver]

Q	A
Branch?	2.0
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes/no
Fixed tickets	#1241
License	MIT

Upgrading to Symfony 5 and adding php 7.4 support in travis while we're at it

[michellesanver]

Currently blocked by: php-enqueue/enqueue-dev#987

[dbu]

looks correct to me.

we still have a lowest version build with 7.1 (hidden from the diff because unchanged), so we don't need to change composer.json for php version support

[rogoit]

Would be good if we have it. Thx for your work!!

[franmomu]

mmmm I think the bundle doesn't use any of "symfony/translation" neither "symfony/asset"

[conradfr]

php-enqueue/enqueue-dev#987 has been merged.

edit: and a new release tagged.

[dbu]

we need to allow enqueue 0.10 to profit from this. enqueue seems to still be in beta state with 0.x releases - for 0.x semver considers every minor version potentially BC breaking...

[conradfr]

Sure, although it doesn't seem they changed much php-enqueue/enqueue-dev@0.9.15...0.10.0

[dbu]

Sure, although it doesn't seem they changed much php-enqueue/[email protected]

yeah, then i am hopeful we can simply allow that version and things will be fine. (i wanted to explain why we need to explicitly allow the version, did not want to imply that it would be a problem)

[lsmith77]

enqueue-bundle dep needs to allow also ^0.10

LiipImagineBundle/composer.json

Line 38 in f8bf61e

"enqueue/enqueue-bundle": "^0.9",

[weaverryan]

Hi! And happy holidays to everyone!

I wanted to help push this forward (and I selfishly need this for a screencast!) so I took Michelle's work (as well as work from a different PR) and polished everything in #1256. That should now be ready.

Thank you!

[michellesanver]

Solved by #1256

[michellesanver]

I see test coverage officially fell but I am happy with our test coverage and merging despite that.