Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose reference type further up following PR 1224 #1263

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

uwej711
Copy link
Contributor

@uwej711 uwej711 commented Jan 27, 2020

Q A
Branch? 2.0
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Following PR #1224 it would be also helpful for us to be able to set the reference type for the generated resolve url when using the filter and the getBrowserPath method of CacheManager

@sveriger
Copy link
Contributor

Hi guys, is this suppose to be merged?

@Gamesh
Copy link
Contributor

Gamesh commented Jul 7, 2020

Hi, can we merge this?

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@dbu dbu merged commit bcd1bb4 into liip:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants