Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix symfony 5.1 deprecations #1282

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Fix symfony 5.1 deprecations #1282

merged 2 commits into from
Jun 25, 2020

Conversation

mynameisbogdan
Copy link
Contributor

@mynameisbogdan mynameisbogdan commented May 31, 2020 •
edited
Loading

Q A
Branch? 2.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1287
License MIT
Doc PR

@mynameisbogdan mynameisbogdan changed the title Add missing params for deprecated tag to make symfony 5.1 happy Fix symfony 5.1 deprecations Jun 1, 2020
@Pixelshaped
Copy link

@dbu please consider merging this PR

dbu
dbu reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh well, sometimes symfony is a pain for maintaining bundles. thanks for working on this.

i have a question on the mime dependency

@dbu dbu merged commit fd0ed71 into liip:master Jun 25, 2020
@dbu
Copy link
Member

dbu commented Jun 25, 2020

are you aware of anything else that should be merged before i tag a new version? i merge a couple of other cleanups about composer requirements and documentation cleanups.
i intend to merge #1290 if there is no build error, and then tag the release.

@mynameisbogdan
Copy link
Contributor Author

No, sadly I'm not aware.

@dbu
Copy link
Member

dbu commented Jun 26, 2020

i am more happy than sad that there are no blockers 😉

here we go: https://github.com/liip/LiipImagineBundle/releases/tag/2.3.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu left review comments

@Pixelshaped Pixelshaped Pixelshaped approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mynameisbogdan @Pixelshaped @dbu