Allow PDF files for the thumbnail generation

[ajay-gupta]

Q	A
New feature?	yes
BC breaks?	no

We can allow PDF files as well for the thumbnail generation which does not require any additional code changes in the bundle.

Please preview and merge.

[dbu]

if everything else works with pdf, we should indeed allow that here, thanks for the PR. i have one question

[dbu]

can you please adjust the test DataManagerTest::testThrowsIfMimeTypeNotImageOneOnFind and testThrowsIfLoaderReturnBinaryWithMimeTypeNotImageOneOnFind to the new exception message? (see travis-ci build)

[ajay-gupta]

can you please adjust the test DataManagerTest::testThrowsIfMimeTypeNotImageOneOnFind and testThrowsIfLoaderReturnBinaryWithMimeTypeNotImageOneOnFind to the new exception message? (see travis-ci build)

Is it only changes in exception message or something more? Please guide.

[dbu]

yes, just the expected message. you can find the phpunit output by clicking on "Details" in the continous-integration/travis-ci/pr line, which leads you e.g. to https://travis-ci.org/github/liip/LiipImagineBundle/jobs/727345430 . ignore the warning and the skipped tests, what is left is the two DataManagerTest failures.

[coveralls]

Coverage remained the same at 72.871% when pulling f41e8ce on ajay-gupta:master into 93ca0f4 on liip:master.

[ajay-gupta]

Please review.

[dbu]

thanks a lot for this improvement!

[Seb33300]

#1122...

[garak]

How is pdf thumbnail is supposed to work?
I tried in a project of mine to generate pdf thumbnails without changing code, but it doesn't work. It generates a pdf in my cache file (not an image)

[ajay-gupta]

It generates file of mime type - image only (file extension will not change). It is working and rendering correctly for example:
<img src="{{ file.pdf | imagine_filter('medium') }}" />

[garak]

Solved by forcing format in configuration. Thank you!

[Seb33300]

How is pdf thumbnail is supposed to work? I tried in a project of mine to generate pdf thumbnails without changing code, but it doesn't work. It generates a pdf in my cache file (not an image)

I have the same issue, the generated thumbnail file is a PDF (not only the extension .pdf, if I edit the file with notepad I can see it starts by %PDF-1.4).
Is there any way to force the format only for PDF?