GitHub Actions

[fbourigault]

Q	A
Branch?	2.0
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#1318
License	MIT
Doc PR

This PR adds PHPUnit runs through GitHub Actions.

Workflow result is visible in my fork: https://github.com/fbourigault/LiipImagineBundle/actions

The following points will be covered in subsequent PRs:

• Nightly jobs allowed to fail.
• Code coverage.
• Removal of Travis-ci.

[fbourigault]

Does anyone have an idea about why the Symfony jobs are not run?

[lsmith77]

do you need some feedback from the community here? feel free to tweet and I will RT

[fbourigault]

do you need some feedback from the community here? feel free to tweet and I will RT

Once this PR is ready, a call for community feedback would be welcomed!

[dbu]

this collides to some extent with #1313 i guess. i still think deciding on what versions to build and all that makes sense, then we can merge 1313 and have this one convert the current status of builds to github actions.

[fbourigault]

I agree to merge #1313 before this one.

[coveralls]

Coverage remained the same at 81.408% when pulling bc39cc6 on fbourigault:github-actions into 4704b34 on liip:master.

[fbourigault]

I moved backward with this PR and the whole move to GitHub Actions will be done in many PRs.

This PR now focus on adding something equivalent to the Travis matrix minus the dev jobs and the code coverage.

[GuilhemN]

Could it be the settings you use in this repository? You are probably limiting the actions that can be executed.

(This is working fine on other repos: nelmio/NelmioApiDocBundle#1766)

[fbourigault]

I checked with @dbu and the Actions permissions settings is on "Allow all actions".

We guess it doesn't work as there is no such workflow in the master branch.

That's the reason why I removed the full switch from Travis to GitHub Actions from this PR.

[lsmith77]

so maybe we just merge and then handle whatever might need more work with a follow up PR?

On Wed, 23 Dec 2020 at 16:34, Fabien Bourigault ***@***.***> wrote: I checked with @dbu <https://github.com/dbu> and the Actions permissions settings is on "Allow all actions". We guess it doesn't work as there is no such workflow in the master branch. That's the reason why I removed the full switch from Travis to GitHub Actions from this PR. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1320 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACJJ55N5EKNCQZ7YIDOQYDSWIEXDANCNFSM4VANAZTA> .

-- regards, Lukas

[fbourigault]

so maybe we just merge and then handle whatever might need more work with a
follow up PR?

That's probably the best option. Review here is more for the base matrix.