Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable WebP support in tests #1329

Merged
merged 1 commit into from
Jan 9, 2021
Merged

Enable WebP support in tests #1329

merged 1 commit into from
Jan 9, 2021

Conversation

fbourigault
Copy link
Contributor

Q A
Branch? 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets
License MIT
Doc PR

This is a tentative to run tests with WebP support enabled.

@coveralls
Copy link

coveralls commented Dec 30, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 83.645% when pulling 7575e49 on fbourigault:enable-webp-tests into db366d2 on liip:2.x.

@fbourigault
Copy link
Contributor Author

Tests are failing: https://github.com/liip/LiipImagineBundle/pull/1329/checks?check_run_id=1626353305#step:9:33

@peter-gribanov do you have an idea about this failure?

@peter-gribanov
Copy link
Contributor

@fbourigault losted file foo bar.jpeg #1331

@peter-gribanov peter-gribanov mentioned this pull request Dec 31, 2020
Merged
@lsmith77 lsmith77 changed the base branch from master to 2.x January 5, 2021 12:49
@lsmith77 lsmith77 merged commit 34219bf into liip:2.x Jan 9, 2021
@fbourigault fbourigault deleted the enable-webp-tests branch January 9, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fbourigault @coveralls @peter-gribanov @lsmith77