Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on doctrine/persistence instead of doctrine/orm #1337

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Depend on doctrine/persistence instead of doctrine/orm #1337

merged 1 commit into from
Jan 5, 2021

Conversation

fbourigault
Copy link
Contributor

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This use the right require-dev dependency for AbstractDoctrineLoader.

This make PHPStan happy (#1336), remove some skipped tests and split off some work of #1305.

@coveralls
Copy link

coveralls commented Jan 4, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 83.571% when pulling edcc567 on fbourigault:fix-doctrine-persistence-dependency into 2c16d31 on liip:master.

@lsmith77 lsmith77 merged commit 80737a4 into liip:master Jan 5, 2021
@lsmith77 lsmith77 mentioned this pull request Jan 5, 2021
Merged
@fbourigault fbourigault deleted the fix-doctrine-persistence-dependency branch January 5, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbourigault @coveralls @lsmith77