Allow installing doctrine/cache 2.0 #1375
Conversation
|
thank you .. if you rebase, PHP CS fixer should work fine again. not sure about the failing test https://github.com/liip/LiipImagineBundle/pull/1375/checks?check_run_id=2645211384#step:10:32 |
alcaeus
force-pushed
the
allow-doctrine-cache-2
branch
from
13c99d2 to
af9a806
Compare
|
I have lots of failures when running the PngQuantPostProcessorTest locally in 2.x, so I can't really tell whether it's related. Looking at the test, it does not seem to involve any of the cache logic I modified (unless I missed something). |
|
@alcaeus ok .. I triggered the github actions. |
|
looks like a tiny CS issue and something with PHP 8.0 is still left |
|
I fixed phpcs, but the PHP 8 issue is unrelated and likely due to incompatible phpunit versions being used across builds. |
|
Friendly bump. Can it be merged? |
composer.json
Outdated
| @@ -19,6 +19,8 @@ | |||
| }, | |||
| "require": { | |||
| "php": "^7.1|^8.0", | |||
| "doctrine/cache": "^1.11|^2.0", | |||
| "psr/cache": "^1.0|^2.0|^3.0", | |||
|
I honestly don't remember why they were moved. I won't have time to wrap up this pull request anytime soon, so I'd like to hand it off for finishing touches. |
|
@alcaeus You should be able to apply my suggestions then this PR should be good to go. |
|
thanks for the work alcaeus and mbabker. i will apply those changes and rebase on 2.x to see if all pans out. |
Co-authored-by: Michael Babker <[email protected]>
This PR adds a new
PsrCacheResolverclass and deprecates the existingCacheResolver. With some changes to the tests, we are able to limit our exposure to doctrine/cache, which is being retired. Allowing installing doctrine/cache 2.0 signals that while the library makes use of the cache interfaces, it does not have any direct dependency on logic from doctrine/cache. At the same deprecating the existing resolver indicates to users that they should no longer rely on doctrine/cache for their needs.