Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of PHPUnit 8 #1381

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Fix deprecation of PHPUnit 8 #1381

merged 1 commit into from
Jun 11, 2021

Conversation

peter-gribanov
Copy link
Contributor

@peter-gribanov peter-gribanov commented Jun 10, 2021

Q A
Branch? 2.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Fix error

expectExceptionMessageRegExp() is deprecated in PHPUnit 8 and will be removed in PHPUnit 9. Use expectExceptionMessageMatches() instead.

… removed in PHPUnit 9. Use expectExceptionMessageMatches() instead.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.066% when pulling ca5fa0a on peter-gribanov:2.x into 00f3ccf on liip:2.x.

@dbu dbu merged commit 7a1779b into liip:2.x Jun 11, 2021
@dbu
Copy link
Member

dbu commented Jun 11, 2021

thanks! i checked if we really need this, as we should support as narrow a range of phpunit as possible, but for as long as we support PHP 7.1 we have have to, phpunit 8 is only available from PHP 7.2 or better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants