Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 6.0 #1431

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Allow Symfony 6.0 #1431

merged 1 commit into from
Nov 12, 2021

Conversation

franmomu
Copy link
Contributor

Q A
Branch? 2.x
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets
License MIT
Doc

@franmomu franmomu mentioned this pull request Nov 12, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 85.733% when pulling c047b52 on franmomu:sf_6 into 8581eed on liip:2.x.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

- name: Remove non-compatible dependencies with Symfony 6
if: matrix.symfony == '6.0.*'
run: |
composer remove enqueue/enqueue-bundle --dev --no-update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is fine

@dbu dbu merged commit 552b3e2 into liip:2.x Nov 12, 2021
@dbu
Copy link
Member

dbu commented Nov 12, 2021

also merged it up into 3.x

@dbu
Copy link
Member

dbu commented Nov 12, 2021

i will wait with tagging the release until symfony 6 is out, just in case.

@mbabker
Copy link
Contributor

mbabker commented Dec 2, 2021

i will wait with tagging the release until symfony 6 is out, just in case.

SF6 is out, can this be released please?

@dbu
Copy link
Member

dbu commented Dec 3, 2021

right. here you go: https://github.com/liip/LiipImagineBundle/releases/tag/2.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants