animated gifs can not be transformed to the webp format #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't efficiently check if the input is an animated gif, therefore we catch the exception and try to convert to gif if converting to webp failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't efficiently check if the input is an animated gif, therefore we
catch the exception and try to convert to gif if converting to webp
failed.
continue fix #1440
When we configure the use of webp
... webp: generate: true ...and we try to generate image from a gif, we get this error
Animated picture is currently only supported on gifNow, it's possible to generate animated webp. I will propose an evolution on
imagine/imaginebut for the moment, this PR fix the bug.Thanks a lot for your review !