Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "directory" to "location" #1507

Merged
merged 1 commit into from
Mar 30, 2023
Merged

change "directory" to "location" #1507

merged 1 commit into from
Mar 30, 2023

Conversation

mysterty
Copy link
Contributor

@mysterty mysterty commented Mar 29, 2023

Q A
Branch? 2.x
Bug fix? yes (bug in documentation)
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc doc fix

Trying to follow this doc, i have error Unrecognized option "directory" under "oneup_flysystem.adapters.profile_photos.local". Available options are "lazy", "linkHandling", "location", "mimeTypeDetector", "permissions", "writeFlags".

Replaced "directory" by "location".

Trying to follow this doc, i have error `Unrecognized option "directory" under "oneup_flysystem.adapters.profile_photos.local". Available options are "lazy", "linkHandling", "location", "mimeTypeDetector", "permissions", "writeFlags".`

Replaced "directory" by "location".
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. looking at the current example in the oneup doc location seems to be the currently correct name.

i guess this changed with some major version of oneup bundle.

@coveralls
Copy link

Coverage Status

Coverage: 79.901%. Remained the same when pulling 4d2bc5b on mysterty:patch-2 into 5d51bd1 on liip:2.x.

@dbu dbu merged commit 5a5db30 into liip:2.x Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants