Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added an "auto_rotate" filter based on exif data #254

Merged
merged 2 commits into from
Jan 29, 2014
Merged

added an "auto_rotate" filter based on exif data #254

merged 2 commits into from
Jan 29, 2014

Conversation

digitalkaoz
Copy link
Contributor

...from the docs...

The auto_rotate filter

The auto_rotate filter rotates the image based on its EXIF data. (this filter should be called as early as possible)
Configuration looks like this:

liip_imagine:
    filter_sets:
        my_thumb:
            filters:
                auto_rotate: ~

lsmith77
lsmith77 reviewed Oct 14, 2013
View reviewed changes
Imagine/Filter/Loader/AutoRotateFilterLoader.php
*/
function load(ImageInterface $image, array $options = array())
{
$exifData = exif_read_data("data://image/jpeg;base64," . base64_encode($image->get('jpg')));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this logic available in Imagine?

/cc @avalanche123

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, not yet, there are several open PRs for metadata support, but non of them is merged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm doesn't seem like @avalanche123 is stil active .. @romainneutron ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a WIP here php-imagine/Imagine#266

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah just found this ticket too .. so are you hopeful this will get merged soon?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm highly open for such feature, we just need to find a nice way to introduce metadata.
I'm a bit busy currently, but I hope we could find some time to merge this in the next weeks. This is the messing feature of Imagine 0.6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitalkaoz can you maybe see if you can push this imagine PR forward?

@digitalkaoz
Copy link
Contributor Author

ping @lsmith77 :)

@digitalkaoz
Copy link
Contributor Author

ping again? @lsmith77

@lsmith77
Copy link
Contributor

redirect ping @havvg @makasim

@havvg
Copy link
Contributor

havvg commented Jan 28, 2014

Could you please apply PSR-2 coding style?

I'm fine with having the read of the meta data directly in here for now. As soon as Imagine provides this feature, this loader has to be refactored.

@makasim
Copy link
Collaborator

makasim commented Jan 28, 2014

I'm fine with having the read of the meta data directly in here for now. As soon as Imagine provides this feature, this loader has to be refactored.

me too

@digitalkaoz
Copy link
Contributor Author

done...

@makasim
Copy link
Collaborator

makasim commented Jan 29, 2014

@havvg could you update develop too after it is merged to master?

@havvg
Copy link
Contributor

havvg commented Jan 29, 2014

I will.

havvg added a commit that referenced this pull request Jan 29, 2014
@havvg
Merge pull request #254 from digitalkaoz/auto_rotate_filter
cb56b14 
added an "auto_rotate" filter based on exif data
@havvg havvg merged commit cb56b14 into liip:master Jan 29, 2014
@havvg
Copy link
Contributor

havvg commented Jan 29, 2014

@makasim develop has been updated.

@digitalkaoz digitalkaoz deleted the auto_rotate_filter branch January 29, 2014 11:55
@romainneutron
Copy link

For you information, Imagine now provides metadata access, see https://imagine.readthedocs.org/en/latest/usage/metadata.html

@digitalkaoz
Copy link
Contributor Author

ill provide a patch these days, thanks for the info :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Milestone
0.20.x
Development

Successfully merging this pull request may close these issues.
5 participants
@digitalkaoz @lsmith77 @havvg @makasim @romainneutron