-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0][WebResolver] Use baseUrl and port while generating image path. #362
[1.0][WebResolver] Use baseUrl and port while generating image path. #362
Conversation
…d subfolder other than 80|443 and '/', respectively;
@mappedinn, @pdziak, @gentisaliu, @ansnap could you please confirm this PR fixes your problem? |
@makasim which version should I download? I tried the |
The changes are in I am not really good in git. I will try to find the command to install it and check it! Thank you @makasim for your help. |
@mappedinn add formapro-forks repository to your composer.json and require it like |
then do composer update liip-imagine-bundle |
@makasim I am really fresh in adding repositories in composer.json. Can you give more details? |
Is it correct? (I can not test it now! I don't have my the laptop now!)
|
@mappedinn try this (I dont tested it): {
"repositories": [
{
"type": "git",
"url": "[email protected]:formapro-forks/LiipImagineBundle.git"
}
],
"require": {
"liip/imagine-bundle": "dev-web-resolver-port-plus-base-url"
}
} |
@makasim thanks... |
@makasim This PR fixes the exact same issue I've been having. |
…se-url [1.0][WebResolver] Use baseUrl and port while generating image path.
merging then |
This PR was based on #353 with some additions and tests.
It has to fix #361, #360, #352, #349