Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0][WebResolver] Use baseUrl and port while generating image path. #362

Merged
merged 2 commits into from
Mar 25, 2014

Conversation

makasim
Copy link
Collaborator

@makasim makasim commented Mar 23, 2014

This PR was based on #353 with some additions and tests.

It has to fix #361, #360, #352, #349

@makasim
Copy link
Collaborator Author

makasim commented Mar 23, 2014

@mappedinn, @pdziak, @gentisaliu, @ansnap could you please confirm this PR fixes your problem?

@mappedinn
Copy link

@makasim which version should I download? I tried the dev-master and the same problem is here!

@mappedinn
Copy link

@makasim The version I have:

  • Updating liip/imagine-bundle (v0.21.1 => dev-master f9de551)
    Checking out f9de551

@mappedinn
Copy link

The changes are in formapro-forks/LiipImagineBundle for the branch web-resolver-port-plus-base-url.

I am not really good in git. I will try to find the command to install it and check it!

Thank you @makasim for your help.

@makasim
Copy link
Collaborator Author

makasim commented Mar 24, 2014

@mappedinn add formapro-forks repository to your composer.json and require it like liip-imagine-bundle: "dev-web-resolver-port-plus-base-url

@makasim
Copy link
Collaborator Author

makasim commented Mar 24, 2014

then do composer update liip-imagine-bundle

@mappedinn
Copy link

@makasim I am really fresh in adding repositories in composer.json. Can you give more details?

@mappedinn
Copy link

Is it correct? (I can not test it now! I don't have my the laptop now!)

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/formapro-forks/LiipImagineBundle/"
        }
    ],
    "require": {
        "liip-imagine-bundle": "dev-web-resolver-port-plus-base-url"
    }
}

@makasim
Copy link
Collaborator Author

makasim commented Mar 24, 2014

@mappedinn try this (I dont tested it):

{
    "repositories": [
        {
            "type": "git",
            "url": "[email protected]:formapro-forks/LiipImagineBundle.git"
        }
    ],
    "require": {
        "liip/imagine-bundle": "dev-web-resolver-port-plus-base-url"
    }
}

@mappedinn
Copy link

@makasim thanks...

@alde
Copy link

alde commented Mar 25, 2014

@makasim This PR fixes the exact same issue I've been having.

makasim added a commit that referenced this pull request Mar 25, 2014
…se-url

[1.0][WebResolver] Use baseUrl and port while generating image path.
@makasim makasim merged commit 904310e into liip:master Mar 25, 2014
@makasim makasim deleted the web-resolver-port-plus-base-url branch March 25, 2014 11:57
@makasim
Copy link
Collaborator Author

makasim commented Mar 25, 2014

merging then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images don't appear in dev environment
4 participants