Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0][loader] cleanup filesystem loader, simplify logic, add factory. #371

Merged
merged 7 commits into from
Mar 31, 2014

Conversation

makasim
Copy link
Collaborator

@makasim makasim commented Mar 27, 2014

This PR removes some config params: formats and data_root. Adds a factory so now we can configure several filesystem loaders.

liip_imagine:
  loaders:
    default:
      filesystem: ~
    foo:
      filesystem:
        data_root: %kernel.root_dir%/../web

The logic is working, still have to add and fix some tests.

@makasim makasim mentioned this pull request Mar 28, 2014
@makasim makasim changed the title [WIP][1.0][loader] cleanup filesystem loader, simplify logic, add factory. [1.0][loader] cleanup filesystem loader, simplify logic, add factory. Mar 29, 2014
@makasim
Copy link
Collaborator Author

makasim commented Mar 29, 2014

@havvg ready. This PR simplify FileSystemLoader logic. Now it does not do any assumptions on the given pass. It does not guess the format or directory etc. Just adds correctly the path to the data_root configured.

This may not satisfy somebody, that's why I waiting for your approve. WOULD really like to get it (:

@makasim makasim mentioned this pull request Mar 31, 2014
9 tasks
makasim added a commit that referenced this pull request Mar 31, 2014
[1.0][loader] cleanup filesystem loader, simplify logic, add factory.
@makasim makasim merged commit fa7313c into liip:master Mar 31, 2014
@makasim makasim deleted the loader-filesystem-rework branch March 31, 2014 08:30
@psytraxx
Copy link

@dbu - i have serios troubles to get this working with data_loader: cmf_media_doctrine_phpcr - is there a problem on my side or is this not implemented yet ?

An exception has been thrown during the rendering of a template ("Could not find resolver for "cmf_319_179" filter type")

    #blog teaser image
    cmf_319_179:
        quality: 80
        data_loader: cmf_media_doctrine_phpcr
        filters:
            thumbnail: { size: [319, 179], mode: outbound }

@dbu
Copy link
Member

dbu commented Mar 31, 2014

@psytraxx you should probably open a new issue for that. i don't know what the state is, but the cmf is only tested with the 0.9 branch of LiipImagineBundle, not the 1.0 so it could be that this was broken at some point.

would of course be good if somebody can set up tests that we see such issues immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants