enabled symfony 2.4 on travis

[digitalkaoz]

enabled symfony framework 2.4 on travis ci

[makasim]

I removed it yesterday in PR #407. The main idea is "If it works on 2.3 it has to work on greater versions too. And we are sure it BC compatible.".

The other reason master sometime not stable and PRs fails because of it.

[makasim]

Do you think we have re-add 2.4? What others can say?

[digitalkaoz]

2.5 is the new master...

[digitalkaoz]

and i think most people use 2,4 nowadays...so better ensure that it works with that version?

[lsmith77]

i think 2.4 would be good to have. also for master you can use allowed_failures:
https://github.com/symfony-cmf/RoutingBundle/blob/master/.travis.yml#L25

[makasim]

@lsmith77 👍

[digitalkaoz]

i dont think allow_failures is a good option, you never see errors happening, so there is no real benefit i think

[lsmith77]

well i do tend to check the travis results now and then ..
the benefit of allowed failures is just that you do test master more often that way .. but you do not get into the problem situation of having your build fail because of a core regression

[digitalkaoz]

exactly...you would need someone who checks travis builds...maybe the github integration can be improved? "all is well, but there were some allowed failures" ? should i add 2.5 with allow_failures?

[lsmith77]

https://twitter.com/lsmith/status/459614308276912128

[digitalkaoz]

yeah, lets wait for replies, would be totally useful...

[digitalkaoz]

"@lsmith sorry, not possible at the moment. allowed_failures is only a passive part of the build."

so whats now? leave it or integrate it?

[lsmith77]

imho add 2.4 as it should be stable. for 2.5 imho there is value even if you do not always check travis. the draw back is of course that builds finish slower if you also test 2.5 (aka master)

[makasim]

let's add 2.4 and 2.5 with allow failure. @digitalkaoz could you update PR?

[digitalkaoz]

already done, lets wait for travis to pass ;)