Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added scrutinizer config #420

Merged
merged 3 commits into from
Apr 28, 2014
Merged

added scrutinizer config #420

merged 3 commits into from
Apr 28, 2014

Conversation

digitalkaoz
Copy link
Contributor

No description provided.

@digitalkaoz
Copy link
Contributor Author

could you enable this bundle on https://scrutinizer-ci.com/ and add the apropriate badges?

@ama3ing
Copy link

ama3ing commented Apr 28, 2014

@digitalkaoz, you forgot about

before_commands:
    - "composer install --prefer-source"

@digitalkaoz
Copy link
Contributor Author

done

@makasim
Copy link
Collaborator

makasim commented Apr 28, 2014

@digitalkaoz I dont admin rights, (I tried)

could you enable this bundle on https://scrutinizer-ci.com/ and add the apropriate badges?

@lsmith77 could you help?

@digitalkaoz
Copy link
Contributor Author

ok, lets wait for lucas...but it could be merged right now i think ;)

@ama3ing
Copy link

ama3ing commented Apr 28, 2014

@digitalkaoz, IMHO you should try this config with your fork before merging.

makasim added a commit that referenced this pull request Apr 28, 2014
@makasim makasim merged commit 0e6a996 into liip:master Apr 28, 2014
@digitalkaoz
Copy link
Contributor Author

@makasim scrutinizer is broken at the moment (we require ext-mongo which isnt available...)

i think we need to wait for a fix or workaround (the travis "hack" wont work) on scrutinizer

@makasim
Copy link
Collaborator

makasim commented Apr 28, 2014

@digitalkaoz should I revert?

@digitalkaoz
Copy link
Contributor Author

nope, not needed, we dont register it on scrutinizer until its fixed ;)

@ama3ing
Copy link

ama3ing commented Apr 28, 2014

@digitalkaoz, can't the tests which require ext-mongo be skipped on crutinizer, or it will fail at other point?

@digitalkaoz
Copy link
Contributor Author

we require doctrine/doctrine-odm which requires ext-mongo...so its complicated...i would wait till @schmittjoh fixes mongo support on scrutinizer

@lsmith77
Copy link
Contributor

ok .. ping me once I should enable it.

@digitalkaoz
Copy link
Contributor Author

a fix would be "check in of composer.lock" but it dont know if we want that...but it would solve all problems with scrutinizer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants