Update WebPathResolverFactory.php

[JJK801]

Hi,

I'm actually updating CmfMediaBundle, i get an error while running test:

Could not find configuration for a filter: resolve

It run well when i make this change.

Is something wrong in my configuration or is it a bug?

[dbu]

one test is failing

[JJK801]

Yes, i just wanted tout open the debate about it

[dbu]

ah sorry, now i see what you are doing. but i am not familiar enough with this, hope @makasim can give us some input here.

[makasim]

There was a bug #429. In few words Safari rejects 301 redirect if they looks same as the current url. So for the first time (when you generate the cache) you would not see images in Safari. The fix 80eb36a just makes thouse urls (one to generate cache and the cache result) look differently.

[JJK801]

@makasim Thanks for the explaination, but i'm still wondering why i get an error, i think there must be a bug by using WebPathResolver as it directly call the /media/cache/resolve url (which must be called only after cache were generated as far i undertand), and it throws my error as in the routing file, URL scheme is /media/cache/{filter}/{path}.

[makasim]

/media/cache/resolve/{filter}/{path} - the url of the action which generates the cache. called only when you do not have the cache.
/media/cache/{filter}/{path} - where web path resolver stores cached image.

[JJK801]

@makasim CacheManager told me the inverse:

public function getBrowserPath($path, $filter, array $runtimeConfig = array())
{
        ...

        return $this->isStored($path, $filter) ?
            $this->resolve($path, $filter) :
            $this->generateUrl($path, $filter)
        ;
}

and routing too:

<route id="liip_imagine_filter" path="/media/cache/{filter}/{path}" methods="GET">
        <default key="_controller">%liip_imagine.controller.filter_action%</default>
        <requirement key="filter">[A-z0-9_\-]*</requirement>
        <requirement key="path">.+</requirement>
</route>

I think i understand what you wanted to do, but the implémentation seems wrong.

IF       the image is not stored in cache
THEN generate url with /media/cache/resolve/{imagePath}
THEN hit the image controller
THEN generate the image cache
THEN redirect to /media/cache/{imagePath}

IF       the image is stored
THEN generate url with /media/cache/{imagePath}
THEN hit the file directly

am i right?
if yes i just have to update the routing file and invert the getBrowserPath condition and it will work.

[JJK801]

@dbu @makasim is this update ok for you? (cf my last commit)

[makasim]

this is not ok, as after this change we would again have problems with Safari

[makasim]

ah, I see, igonre the comment

[makasim]

So you changed urls used to generate and the actual url of cached image?
Now its like

/media/cache/resolve/{filter}/{path} - the url of the action which generates the cache. called only when > you do not have the cache.
/media/cache/{filter}/{path} - where web path resolver stores cached image.

Could you confirm?

[JJK801]

@makasim yes, thats it :) IMO it's prettiest to store in the /media/cache folder (resolve folder means nothing) and use the /media/cache/resolve path to execute the resolution.

[makasim]

@JJK801 yes that was my intention too but I think I messed it up.

merging!

thanks.

[JJK801]

@makasim @dbu thanks guys 👍

[makasim]

tagged it: https://github.com/liip/LiipImagineBundle/releases/tag/1.0.4