Allowed a file extension to be inferred for source files without one #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave an extension.
| @@ -69,7 +69,14 @@ public function find($path) | |||
| } | |||
|
|
|||
| if (!$absolutePath) { | |||
| throw new NotFoundHttpException(sprintf('Source image not found in "%s"', $absolutePath)); | |||
| if(!empty($targetFormat) && is_file($name)) | |||
| { | |||
There was a problem hiding this comment.
please fix CS. curly braces should be on the same line than the control structures (if, else...)
There was a problem hiding this comment.
and there should be a space aka if (
|
So with the fixed formatting, is it good to go? Or are there some other concerns? |
|
hmm i think so yes .. been pondering if there is any new security risk, but i guess not. |
| if(!empty($targetFormat) && is_file($name)) { | ||
| $absolutePath = $name; | ||
| } | ||
| else { |
There was a problem hiding this comment.
else should be on the same line than the closing curly brace
lsmith77
added a commit
that referenced
this pull request
Jan 30, 2012
Allowed a file extension to be inferred for source files without one
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have a file (e.g.
file/something) on the file system without a file extension, this PR allows them to be found by looking forfile/somethingwhenfile/something.pngis used in the url.