Support custom output format for each filter set #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings back the "format" configuration option. However, the target path is not modified in any way.
| @@ -21,7 +21,8 @@ | |||
| "symfony/finder": "~2.3", | |||
| "symfony/filesystem": "~2.3", | |||
| "symfony/options-resolver": "~2.3", | |||
| "symfony/framework-bundle": "~2.3" | |||
| "symfony/framework-bundle": "~2.3", | |||
| "dflydev/apache-mime-types": "~1.0" | |||
There was a problem hiding this comment.
I'd prefer to use mimetype and extension guessers shipped with this bundle.
|
any news on this ? |
makasim
added a commit
that referenced
this pull request
Sep 22, 2014
Support custom output format for each filter set
|
looks good imho. |
|
thanks for the @teohhanhui patch and ping @tentacode |
|
Ah, one thing, it may be good to update the doc too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the "format" configuration option.
However, the target path is not modified in any way.