check if runtimeconfig path is stored #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 could you add a test |
|
we have to places where we generate runtime path, here in CacheManager and in the controller: https://github.com/liip/LiipImagineBundle/blob/master/Controller/ImagineController.php#L125 What about a methond in the CacheManager which can generate such a path? The method has to be reused in getBrowserPath and in the controller. |
|
Should be all good now @makasim. Let me know if there are any issues. |
| * @param string $path | ||
| * @param array $runtimeConfig | ||
| */ | ||
| public function getRuntimeConfigPath($path, array $runtimeConfig) |
There was a problem hiding this comment.
getRuntimePath would be better IMO
makasim
added a commit
that referenced
this pull request
Sep 15, 2014
check if runtimeconfig path is stored
|
Good work - 🍺 |
|
tagged it as 1.0.5 |
|
Thanks 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR in favour of #497
If a runtime config is specified, the path will be modified to match the hashed path.