fixed ImagineLoader - cache prefix was not used in urls #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
added a commit
that referenced
this pull request
Oct 12, 2011
fixed ImagineLoader - cache prefix was not used in urls
|
@LouTerrailloune: yes .. this is how it is in AvalancheImagineBundle, but imho this didn't make sense .. then again maybe i should have asked for feedback first .. so what do you guys think? |
|
@lsmith77: I didn't find any good reason for this too. Not a bad thing to remove it then. |
|
I just fixed the bug introduced in 40a3799 commit which was intended to change code in order to always use the cache prefix (see commit message). I don't use See readme file. Both parts (code & docs) should be consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.