Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed TransformerInterface #603

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Removed TransformerInterface #603

merged 2 commits into from
Jun 2, 2015

Conversation

rvanlaarhoven
Copy link
Contributor

Removed the obsolete TransformerInterface. Together with it, I removed the documentation part about Extending the image loader with data transformers, which was simply an explanation on how to use the already removed ExtendedFileSystemLoader.

@makasim
Copy link
Collaborator

makasim commented May 23, 2015

Unfortunately we can not remove it because we already released a stable version, and it is a BC break if remove it. We have to mark it as deprecated.

From the other side I dont think it is used much so we may do an exception in this particular case.
@havvg @lsmith77 wdyt?

@lsmith77
Copy link
Contributor

i think its better to mark it deprecated.

@rvanlaarhoven
Copy link
Contributor Author

Okay, just let me know what to add as the deprecated message, so I can update the pull request.

@makasim
Copy link
Collaborator

makasim commented May 24, 2015

@rvanlaarhoven It does not matter much, just something like "It will be removed in 2.0"

@rvanlaarhoven
Copy link
Contributor Author

Updated the pull request.

@lsmith77
Copy link
Contributor

+1 from me .. will let @makasim make the final decision

@havvg
Copy link
Contributor

havvg commented May 28, 2015

+1 on deprecation over BC break

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label May 29, 2015
makasim added a commit that referenced this pull request Jun 2, 2015
@makasim makasim merged commit 98b571b into liip:master Jun 2, 2015
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jun 2, 2015
@makasim
Copy link
Collaborator

makasim commented Jun 2, 2015

Thanks @rvanlaarhoven

@rvanlaarhoven rvanlaarhoven deleted the transformer branch June 2, 2015 19:03
@christoph-hautzinger
Copy link

i am currently upgrading from 0.x to 1.x - what was the reason to remove the transformers?
and how is the suggested way to generate preview imaegs from pdfs now? (<-- more important question ;))
thanks for answer :)

@Sander-Toonen
Copy link

I have the same question as @christoph-hautzinger. Is there an alternative way to generate thumbnails from PDFs and if so, could we add something about the removal of the TransformerInterface in UPGRADE.md?

@lucasaba
Copy link
Contributor

Same question here... I'm trying to creating a custom data loader and a custom cache resolver but...it's quite messy. Is there a better way now ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants