Updated docs for features introduced in Symfony 2.4 #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we still support symfony 2.3. So there is no way to use new symfony features without providing BC. |
|
Ok. The second suggestion still makes sense though: As the filterAction() doesn't actually depend on the request, I suggest injecting an empty request object |
lsmith77
added
the
State: Reviewing
| @@ -263,7 +263,7 @@ A simple example showing how to change the filter configuration dynamically. | |||
| $this->cacheManager->store($filteredBinary, $path, $filter); | |||
| } | |||
|
|
|||
| return new RedirectResponse($this->cacheManager->resolve($path, $filter), 301); | |||
| return new RedirectResponse($this->cacheManager->resolve($path, $filter), Response::HTTP_MOVED_PERMANENTLY); | |||
There was a problem hiding this comment.
please add a note here to say that for Symfony 2.3 devs should use 301 instead of the constant.
|
ping .. |
|
Done. Sorry for the delay |
lsmith77
added a commit
that referenced
this pull request
Nov 2, 2015
Updated docs for features introduced in Symfony 2.4
lsmith77
removed
the
State: Reviewing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony 2.4 introduced constants for HTTP status codes to make code more readable. See: http://symfony.com/blog/new-in-symfony-2-4-using-constants-for-http-status-code.
Also introduced was the request stack with the request service being deprecated for removal in 3.0. See: http://symfony.com/blog/new-in-symfony-2-4-the-request-stack. As the filterAction() doesn't actually depend on the request, I suggest injecting an empty request object.