Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed UrlGenerator deprecations from symfony 2.8 #673

Merged
merged 1 commit into from
Dec 10, 2015
Merged

Removed UrlGenerator deprecations from symfony 2.8 #673

merged 1 commit into from
Dec 10, 2015

Conversation

sebastianblum
Copy link
Contributor

Hello!

With Symfony 2.8, the UrlGenerator params have changed to generate absolute urls.
Instead of true, the param should be UrlGeneratorInterface::ABSOLUTE_URL

I changed the functionality to work with symfony 3.0.

Greetings from munich,
Sebastian

@makasim
Copy link
Collaborator

makasim commented Dec 10, 2015

Will this work for symfony 2.3? It is the lowest version we support, and it should not be broken.

@sebastianblum
Copy link
Contributor Author

makasim added a commit that referenced this pull request Dec 10, 2015
Removed UrlGenerator deprecations from symfony 2.8
@makasim makasim merged commit c2dfddf into liip:master Dec 10, 2015
@makasim
Copy link
Collaborator

makasim commented Dec 10, 2015

Thanks

@sebastianblum
Copy link
Contributor Author

Thank you @makasim for merging.
Do you know when the next minor version on packagist is planned?

@makasim
Copy link
Collaborator

makasim commented Dec 10, 2015

@sebastianblum
Copy link
Contributor Author

great @makasim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants