Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added contributing docs #681

Merged
merged 3 commits into from
Dec 29, 2015
Merged

added contributing docs #681

merged 3 commits into from
Dec 29, 2015

Conversation

helios-ag
Copy link
Contributor

Contributing docs

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 18, 2015
@makasim
Copy link
Collaborator

makasim commented Dec 28, 2015

@javiereguiluz Could you please review.

javiereguiluz
javiereguiluz reviewed Dec 28, 2015
View reviewed changes
CONTRIBUTING.md

## Feature request

If you think a feature is missing, please report it or implement it. If you report it, describe the more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

describe the more precisely -> describe precisely

@javiereguiluz
Copy link
Contributor

Very nice! @helios-ag thanks for contributing this guide.

@helios-ag
Copy link
Contributor Author

@javiereguiluz done

@javiereguiluz
Copy link
Contributor

@helios-ag thank you! It looks nice 👍

makasim
makasim reviewed Dec 28, 2015
View reviewed changes
CONTRIBUTING.md
To run tests, use the following command:

``` bash
$ phpunit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./bin/phpunit

@helios-ag
Copy link
Contributor Author

@makasim done

makasim added a commit that referenced this pull request Dec 29, 2015
@makasim
Merge pull request #681 from helios-ag/contributing
2bb76e6 
added contributing docs
@makasim makasim merged commit 2bb76e6 into liip:master Dec 29, 2015
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Dec 29, 2015
@makasim
Copy link
Collaborator

makasim commented Dec 29, 2015

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@helios-ag @makasim @javiereguiluz @lsmith77