Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding optipng post transformer #692

Merged
merged 5 commits into from
Jan 21, 2016
Merged

Adding optipng post transformer #692

merged 5 commits into from
Jan 21, 2016

Conversation

benjamin-hubert
Copy link
Contributor

No description provided.

@lsmith77 lsmith77 added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jan 9, 2016
@makasim
Copy link
Collaborator

makasim commented Jan 18, 2016

tests fails, could @GOUAILLE please fix them?

https://travis-ci.org/liip/LiipImagineBundle/jobs/101123613

@makasim
Copy link
Collaborator

makasim commented Jan 20, 2016

Have you tested it in real world? Does it work for you?

@benjamin-hubert
Copy link
Contributor Author

Yes, but my project is private atm and i can't show you an example

@makasim
Copy link
Collaborator

makasim commented Jan 20, 2016

I do not need an example, just need confirmation that the solution was tested in real world.

@makasim
Copy link
Collaborator

makasim commented Jan 20, 2016

@GOUAILLE Could you please add some words to the documentation about the new post proceesor

https://github.com/liip/LiipImagineBundle/blob/master/Resources/doc/filters.rst#post-processors

@benjamin-hubert
Copy link
Contributor Author

It is working in real world.

Doc updated.

makasim added a commit that referenced this pull request Jan 21, 2016
Adding optipng post transformer
@makasim makasim merged commit 40e98ef into liip:master Jan 21, 2016
@lsmith77 lsmith77 removed the State: Reviewing This item is being reviewed to determine if it should be accepted. label Jan 21, 2016
@makasim
Copy link
Collaborator

makasim commented Jan 21, 2016

Thanks

@benjamin-hubert benjamin-hubert deleted the feature/optipng branch January 21, 2016 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants