Input is added twice in the OptiPngProcessor. #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwilson
changed the title
|
Sorry to bother you again @lsmith77, would you mind looking at this one? |
| @@ -74,7 +74,6 @@ public function process(BinaryInterface $binary) | |||
| } | |||
|
|
|||
| $pb->add($input = tempnam(sys_get_temp_dir(), 'imagine_optipng')); | |||
There was a problem hiding this comment.
This line should be removed as $input is defined in line 62
alexwilson
force-pushed
the
756-merge-conflict
branch
from
3360e17 to
34f4401
Compare
|
ah .. there it is already |
|
Yep, tests passing - Not sure how it slipped by in the rebase, I must have resolved one of the merges incorrectly the first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @notrix for spotting this!