Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CHANGELOG.md #788

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Sep 7, 2016

This pull-request resolves #786 and replaces #781. I've created a new, auto-generated CHANGELOG.md that details pull-requests per-release, according to the GitHub API.

The option to both remove and update the changelog has been thrown around: I hold the opinion that the changelog serves an important purpose by providing a historical overview of the code activity regardless of the delivery means used to acquire the source code. As such, I propose we merge a new changelog updated to accurately reflect this repositories activity.

Per issue #786, I used the skywinder/github-changelog-generator executable to generate the new changelog file. I fumbled with a few different combinations of command arguments, and settled on the following, which offered the cleanest result, in my opinion.

github_changelog_generator \
  -u liip \
  -p LiipImagineBundle \
  -t <hidden> \
  --no-issues \
  --simple-list

If someone else decides to download skywinder/github-changelog-generator and lands on a better argument combination, I'm open to changing it if any strong opinions are voiced.

…erator

Used the following CLI command argument to create CHANGELOG.md

github_changelog_generator \
  -u liip \
  -p LiipImagineBundle \
  -t <hidden> \
  --no-issues \
  --simple-list

fixed duplicate changelog generation run
@robfrawley robfrawley force-pushed the feature-add-changelog branch from 90584f6 to 1c5302f Compare September 7, 2016 12:04
@alexwilson
Copy link
Collaborator

lgtm! 👍

@lsmith77 lsmith77 merged commit 740c7e3 into liip:master Sep 8, 2016
@robfrawley robfrawley deleted the feature-add-changelog branch January 9, 2017 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHANGELOG.md
3 participants