Wrap relative path with asset() Twig function

[bocharsky-bw]

I think it's a good idea to adjust relative path with asset() Twig function, isn't it?

[robfrawley]

@bocharsky-bw So, I know the Asset Component (documentation here) was introduced in Symfony 2.7, but did this function exist prior to the component being compartmentalized into its own release?

Most importantly, was this function available in a default Symfony 2.3 installation? I honestly don't remember if it was, and I do know we want to retain explicit 2.3 support on this branch...

That said, if it did exist, let me know, otherwise, I'll merge it into the 2.x branch instead, as we are breaking BC on that branch, and I do like the overall sentiment of this change.

[lsmith77]

http://symfony.com/doc/2.3/reference/twig_reference.html#asset

[robfrawley]

@lsmith77 Looks like asset's been around for quite some time. I assume there are no objections to utilizing this in our examples? It is better practice to make use of the helper functions in a real project anyway. I'll merge tomorrow morning unless anyone objects.

[robfrawley]

@lsmith77 @antoligy

Also, I didn't intentionally turn on the Coveralls verbose comment reporting when I enabled coverage reporting (perhaps that's the new default?), and, well, I'm not quite sure I like it, either (if you have no idea what I'm talking about, check up in this discussion thread a bit ;-). Thoughts?

I'm inclined to go ahead and disable those verbose comments in Coverall's settings... The repo commit hooks should be enough (where it already checks Travis, StyleCI, and Coveralls now). We don't need strings of comments from the coveralls bot on top of that too, do we?

[lsmith77]

@robfrawley imho its sufficient if such coverage infos can easily be seen via a link in the checks.

[bocharsky-bw]

Now I'm not sure about this changes. What if assets will be hosted on a CDN? Then the asset() function will build an absolute URL for them I think. Looks like it works for relative paths only.

[lsmith77]

the function lets you configure different CDN base urls .. but I guess for most users it makes sense to use the asset filter ..

[alexwilson]

🎉