Skip tests with dependencies that are not installed by default #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably related to the fact that the bundle's dependency on FrameworkBundle pulled in a lot of packages in the past. Now that with the release of Symfony 3.2 the FrameworkBundle doesn't pull in the whole world anymore, it's probably the best idea to update the required packages for this package. |
|
Good point. I created an alternative PR to require the components explicitly: #832 |
|
This feels like something we should probably fix in the 2.0 branch, and it's probably for the best that the tests fail in other versions |
|
No longer needed now that #832 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just checked out the repository for the first time, ran phpunit, and got a bunch of fails, one of which was a fatal PHP error that stopped the tests because symfony templating was not installed (
PHP Fatal error: Class 'Symfony\Component\Templating\Helper\Helper' not found).By skipping the tests that require components that are not installed by default at least all the tests run out of the box.
Alternatively the missing dependencies could be added to the dev dependencies but I did not want to be presumptuous and just add them.