Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.9.0 #983

Merged
merged 2 commits into from
Sep 2, 2017
Merged

Release 1.9.0 #983

merged 2 commits into from
Sep 2, 2017

Conversation

robfrawley
Copy link
Collaborator

@robfrawley robfrawley commented Aug 31, 2017

Q A
Branch? 1.0
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Update the CHANGELOG.md and UPGRADE.md files for the 1.9.0 release.

@robfrawley robfrawley added the State: Reviewing This item is being reviewed to determine if it should be accepted. label Aug 31, 2017
@robfrawley robfrawley added this to the 1.9.0 milestone Aug 31, 2017
@robfrawley robfrawley self-assigned this Aug 31, 2017
@robfrawley
Copy link
Collaborator Author

robfrawley commented Aug 31, 2017

It would be much appreciated if @antoligy or @cedricziel can take a moment to review the release changes so that I can get the 1.9.0 release officially tagged. There have been a bunch of recent requests for the new tag, so I took the time to merge all the outstanding 1.9.0-labeled PRs and fix some issues introduced. I think we're ready to go!

I took some time to cleanup and slightly reformat the CHANGELOG and UPGRADE files in the second commit. Let me know if there are any objections to the changes.

This turned out to be a failure hefty release:

  • [Tests] Fix filesystem loader deprecation message in tests. #982 (robfrawley)
  • [Filter] Add "centerright" and "centerleft" positions to background filter. #974 (cmodijk)
  • [Config] Allow to configure the HTTP response code for redirects. #970 (lstrojny)
  • [Console] Add "--force" option, and rename "--filters" to "--filter", and prittify/detail output for image resolve command. #967 (robfrawley)
  • [CS] Fix two docblock annotations. #965 (imanalopher)
  • [Data Loader] [Deprecation] The FileSystemLoader no longer accepts an array of data root paths; instead pass a FileSystemLocator, which should instead be passed said paths. #963 (robfrawley, rpkamp)
  • [Composer] Allow avalanche123/Imagine version 0.7.0. #958 (robfrawley)
  • [Data Loader] [Documentation] Add chain loader documentation. #957 (robfrawley)
  • [Data Loader] Add chain loader implementation. #953 (robfrawley)
  • [CS] Fix templating extension method return type. #951 (imanalopher)
  • [Dependency Injection] Fix compiler pass log message typo. #947 (you-ser)
  • [Travis] Default to trusty container image (with precise image for php 5.3). #945 (robfrawley)
  • [Enqueue] Use simplified transport configuration. #942 (makasim)
  • [Filter] Add resolution loader implementation. #941 (robfrawley)
  • [Travis] Remove Symfony 3.3 from allowed failures. #940 (robfrawley)
  • [Utility] Use simplified Symfony kernel version comparison operation. #939 (robfrawley)

@robfrawley
Copy link
Collaborator Author

robfrawley commented Sep 1, 2017

@antoligy @cedricziel Can I get a quick review so we can tag the 1.9.0 release? You just need to review the first commit in this PR (a3bde59); the second one is just formatting changes (hence its size) and doesn't need to be reviewed beyond a passing glance.

@alexwilson
Copy link
Collaborator

Sorry for the delay, have been super rammed! Thanks for preparing this, I'll check it out later on today!

@robfrawley
Copy link
Collaborator Author

robfrawley commented Sep 1, 2017

No worries; I can absolutely understand being swamped and not having time to allocate to every open source project! ;-) Thanks for setting aside some time. 🥇

As I mentioned, no need to fully review the second commit (it's massive as it touches every line of the changelog) but do take a second to review the new formatting of the CHANGELOG.md and UPGRADE.md files by viewing their rendered versions. The changes were all done via whole-file regular expressions, so the changes should be consistent throughout the file.

@cedricziel
Copy link
Collaborator

Thx for the preparation!

@robfrawley
Copy link
Collaborator Author

@cedricziel Thanks for handling and merging a few PRs over the last few weeks; I didn't have any time to contribute to this project over the last month and I know a few people were becomming irritated in their PRs not being merged, so I'm glad you handled some. Between us three we're keeping this project moving forward pretty well, IMHO.

@cedricziel
Copy link
Collaborator

Thx to you guys as well - IMHO it's hard to always be on spot for open source and I'm glad there's the 3 of us :)

@robfrawley
Copy link
Collaborator Author

Unless anyone adds any additional comments, I'll merge this and tag the new release tomorrow sometime during the day.

@robfrawley robfrawley merged commit c72e914 into liip:1.0 Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Reviewing This item is being reviewed to determine if it should be accepted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants