Skip to content

Commit

Permalink
Test on Windows, Linux, MacOS Intel (#169)
Browse files Browse the repository at this point in the history
* Test on Windows, Linux, MacOS Intel

* FIX: Make install work on winodows

I think that a character encoding error in the README is causing the error on windows.

* FIX: macOS intel warnings

I think the issues is that torch dropped support for macOS Intel upon release of 2.3. And torch < 2.3 doesnt play well with Numpy 2. So the fix here is to downgrade numpy versions to 1 for macOS Intel only.

* FIX: Dont need to upload code coverage for every OS
  • Loading branch information
scott-huberty authored Oct 3, 2024
1 parent 5f2c341 commit 8598b63
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
17 changes: 15 additions & 2 deletions .github/workflows/test_pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,25 @@ on:

jobs:
test:
runs-on: macos-latest
runs-on: ${{ matrix.os }}

strategy:
matrix:
os:
- ubuntu-latest
- macos-latest # arm64 (Apple Silicon)
- macos-13 # latest Intel release
- windows-latest

steps:
- uses: actions/checkout@v4
- name: Set up Python 3.9
uses: actions/setup-python@v5
with:
python-version: "3.9"
- name: Force numpy < 2 on MacOS Intel
if: matrix.os == 'macos-13'
run: pip install 'numpy<2'
- name: Install Pylossless & Deps
run: pip install -e .
- name: Test import
Expand All @@ -29,7 +41,8 @@ jobs:
- name: Test Pipeline
run: |
coverage run -m pytest
- name: Upload coverage to codecov
- name: Upload coverage to codecov (Only do this for the ubuntu-latest job)
if: matrix.os == 'ubuntu-latest'
uses: codecov/codecov-action@v3
with:
token: ${{secrets.CODECOV_TOKEN}}
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
extras_require[extra] = requirements_extra

this_directory = Path(__file__).parent
long_description = (this_directory / "README.md").read_text()
long_description = (this_directory / "README.md").read_text(encoding="utf-8")

qc_entry_point = ["pylossless_qc=pylossless.dash.pylossless_qc:main"]
setup(
Expand Down

0 comments on commit 8598b63

Please sign in to comment.