-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug issue #175 #176
Merged
christian-oreilly
merged 6 commits into
main
from
175-typeerror-write_raw_bids-got-an-unexpected-keyword-argument-events_data
Nov 11, 2024
Merged
Fix bug issue #175 #176
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
975078e
Fix bug issue #175
christian-oreilly 79f7cc3
Code linting.
christian-oreilly 70f179e
Update pylossless/tests/test_bids.py
christian-oreilly 79b926d
Update pylossless/tests/test_bids.py
christian-oreilly a3f9ea7
Update pylossless/tests/test_bids.py
christian-oreilly 92b6b50
Remove print, clean test files, rename test.
christian-oreilly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import pylossless as ll | ||
import mne | ||
import numpy as np | ||
import pytest | ||
import shutil | ||
|
||
|
||
@pytest.mark.filterwarnings("ignore:Converting data files to EDF format") | ||
def test_convert_dataset_to_bids(tmp_path): | ||
"""Make sure MNE's annotate_break function can run.""" | ||
def edf_import_fct(path_in): | ||
# read in a file | ||
raw = mne.io.read_raw_edf(path_in, preload=True) | ||
print(raw.annotations) | ||
return raw, np.array([[0, 0, 0]]), {"test": 0, "T0": 1, "T1": 2, "T2": 3} | ||
|
||
testing_path = mne.datasets.testing.data_path() | ||
fname = testing_path / "EDF" / "test_edf_overlapping_annotations.edf" | ||
import_args = [{"path_in": fname}] | ||
bids_path_args = [{'subject': '001', 'run': '01', 'session': '01', | ||
"task": "test"}] | ||
ll.bids.convert_dataset_to_bids( | ||
edf_import_fct, | ||
import_args, | ||
bids_path_args, | ||
bids_root=tmp_path / "bids_dataset", | ||
overwrite=True | ||
) | ||
shutil.rmtree(tmp_path / "bids_dataset") | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the
shutil.rmtree
isn't actually necessary becausetmp_path
is a magicpytest
fixture and will tear down the temporary directory for you 🙂