Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug issue #175 #176

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pylossless/bids.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def convert_recording_to_bids(
write_kwargs["allow_preload"] = True

write_raw_bids(
raw, bids_path=bids_path, events_data=events, event_id=event_id, **write_kwargs
raw, bids_path=bids_path, events=events, event_id=event_id, **write_kwargs
)

return bids_path
Expand Down
29 changes: 29 additions & 0 deletions pylossless/tests/test_bids.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import pylossless as ll
import mne
import numpy as np
import pytest
import shutil


@pytest.mark.filterwarnings("ignore:Converting data files to EDF format")
def test_convert_dataset_to_bids(tmp_path):
"""Make sure MNE's annotate_break function can run."""
def edf_import_fct(path_in):
# read in a file
raw = mne.io.read_raw_edf(path_in, preload=True)
print(raw.annotations)
return raw, np.array([[0, 0, 0]]), {"test": 0, "T0": 1, "T1": 2, "T2": 3}

testing_path = mne.datasets.testing.data_path()
fname = testing_path / "EDF" / "test_edf_overlapping_annotations.edf"
import_args = [{"path_in": fname}]
bids_path_args = [{'subject': '001', 'run': '01', 'session': '01',
"task": "test"}]
ll.bids.convert_dataset_to_bids(
edf_import_fct,
import_args,
bids_path_args,
bids_root=tmp_path / "bids_dataset",
overwrite=True
)
shutil.rmtree(tmp_path / "bids_dataset")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the shutil.rmtree isn't actually necessary because tmp_path is a magic pytest fixture and will tear down the temporary directory for you 🙂

Loading