Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging code from Taylor's fork #198

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Conversation

christian-oreilly
Copy link
Collaborator

Closes #192

@christian-oreilly christian-oreilly linked an issue Dec 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (c647153) to head (6371dec).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   80.81%   80.81%           
=======================================
  Files          22       22           
  Lines        1282     1282           
=======================================
  Hits         1036     1036           
  Misses        246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-oreilly christian-oreilly marked this pull request as ready for review December 10, 2024 01:13
@christian-oreilly
Copy link
Collaborator Author

@jadesjardins if you could check if the code of this PR works for Q1K and @Andesha if it works EEGNet, that would be great! If it works for both, then we are good to go. If it doesn't work with either, I am happy to work with both of you to make sure we can modify the repo so that it does.

@christian-oreilly christian-oreilly added this to the 0.03 milestone Dec 10, 2024
@christian-oreilly christian-oreilly changed the title Update readme Merging code from Taylor's fork Dec 10, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@christian-oreilly christian-oreilly merged commit 5f4df91 into main Dec 12, 2024
8 checks passed
@christian-oreilly christian-oreilly deleted the 192-hpc-friendly-pylossless branch December 12, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPC-friendly PyLossless
2 participants