Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: replace mne.Raw with mne.io.Raw #212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

scott-huberty
Copy link
Member

mne.io.Raw not mne.Raw.

Mostly used in docstring but caught one instance in the actual code (which would throw an error).

@christian-oreilly do you want a test?

@scott-huberty scott-huberty changed the title FIX: Use the correct type FIX: replace mne.Raw with mne.io.Raw Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.27%. Comparing base (5f4df91) to head (f56a5df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pylossless/pipeline.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   80.81%   83.27%   +2.46%     
==========================================
  Files          22       26       +4     
  Lines        1282     1698     +416     
==========================================
+ Hits         1036     1414     +378     
- Misses        246      284      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christian-oreilly
Copy link
Collaborator

Not sure it is worth adding a test just to hit a single line checking a type. I think this is definitely a net + and it does not hurt the coverage (just did not improve it). I would merge regardless of the codecov complaint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants