Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import menu entry does not work #51

Assignees
Labels
bug Something isn't working

Comments

@MichaelBailly
Copy link
Contributor

The calendar (+) button -> Import does not work.

Error in the console:

angular-strap.js:2501 Error: [$injector:unpr] Unknown provider: davImportServiceProvider <- davImportService <- CalCalendarImportController
http://errors.angularjs.org/1.3.20/$injector/unpr?p0=davImportServiceProvider%20%3C-%20davImportService%20%3C-%20CalCalendarImportController
@MichaelBailly MichaelBailly added the bug Something isn't working label Aug 18, 2020
@itswillta itswillta self-assigned this Aug 20, 2020
@itswillta
Copy link
Contributor

itswillta commented Aug 20, 2020

This issue is caused by the fact that the davImportService is defined in linagora.esn.dav.import, which currently only resides inside the esn-frontend-contacts repo: https://github.com/OpenPaaS-Suite/esn-frontend-contacts/blob/02db0a636eed4935e3901206615586f9a546734d/src/linagora.esn.dav.import/app/common/dav-import-api-client.service.js#L8

Previously, in the old codebase, there was a separate linagora.esn.dav.import repository to do that: https://github.com/linagora/linagora.esn.dav.import/blob/6711eb0a0610d33599479aa7a837330d697e1598/frontend/app/import/dav-import.service.js#L7 (because it is required in both linagora.esn.contacts and linagora.esn.calendar).

So I suggest that we either move linagora.esn.dav.import to a separate repository or move it to somewhere in esn-frontend-common-libs. Wdyt @MichaelBailly @tuanlc @piavgh?

@itswillta itswillta added the question Further information is requested label Aug 20, 2020
@tuanlc
Copy link

tuanlc commented Aug 20, 2020

Yes, agree. But from what I know linagora.esn.dav.import only contains common services to import, so how about having a dedicated library for it.

@itswillta
Copy link
Contributor

Yes, agree. But from what I know linagora.esn.dav.import only contains common services to import, so how about having a dedicated library for it.

Yes, agree. That's also what I meant:

I suggest that we either move linagora.esn.dav.import to a separate repository

@piavgh
Copy link
Contributor

piavgh commented Aug 20, 2020

A separate library is better. esn-frontend-common-libs is so big already :D

@itswillta itswillta removed their assignment Aug 21, 2020
@itswillta itswillta removed the question Further information is requested label Aug 21, 2020
@tuanlc tuanlc self-assigned this Aug 21, 2020
bot-linagora pushed a commit to linagora/linagora.esn.dav.import that referenced this issue Aug 25, 2020
bot-linagora pushed a commit to linagora/linagora.esn.dav.import that referenced this issue Aug 25, 2020
…aster'

linagora/esn-frontend-calendar#51 Add CORS support

See merge request linagora/lgs/openpaas/linagora.esn.dav.import!22
tuanlc pushed a commit to linagora/esn-dav-import-client that referenced this issue Aug 26, 2020
tuanlc pushed a commit to linagora/esn-api-client that referenced this issue Aug 26, 2020
bot-linagora pushed a commit to linagora/linagora.esn.dav.import that referenced this issue Aug 26, 2020
bot-linagora pushed a commit to linagora/linagora.esn.dav.import that referenced this issue Aug 26, 2020
…aster'

linagora/esn-frontend-calendar#51 add cors dependency

See merge request linagora/lgs/openpaas/linagora.esn.dav.import!23
@tuanlc tuanlc reopened this Aug 26, 2020
tuanlc pushed a commit to linagora/esn-frontend-common-libs that referenced this issue Aug 26, 2020
…dar/issues#51

linagora/esn-frontend-calendar#51 move upload file request from linagora.esn.dav.import to core file module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment