Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text preview window panics on Linux #231

Closed
alerque opened this issue Mar 11, 2021 · 1 comment · Fixed by #232
Closed

Text preview window panics on Linux #231

alerque opened this issue Mar 11, 2021 · 1 comment · Fixed by #232

Comments

@alerque
Copy link

alerque commented Mar 11, 2021 •
edited
Loading

I just tried the new text preview window from #223 on Linux, and it panics the moment I click on the menu item:

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', runebender-lib/src/virtual_font.rs:165:18
cmyr added a commit that referenced this issue Mar 11, 2021
@cmyr
Don't panic on missing glyph in virtual_font
dac79d0 
This is a particular problem because we always ensure .notdef is
present in the vfont, even if it doesn't exist in the font.

fixes #231
@cmyr cmyr mentioned this issue Mar 11, 2021
Merged
@cmyr
Copy link
Member

cmyr commented Mar 11, 2021

Oops, thanks! This was just general sloppiness, it would crash anytime the font didn't contain the the '.notdef' glyph.

@cmyr cmyr closed this as completed in #232 Mar 11, 2021
cmyr added a commit that referenced this issue Mar 11, 2021
@cmyr
Don't panic on missing glyph in virtual_font
3cf949b 
This is a particular problem because we always ensure .notdef is
present in the vfont, even if it doesn't exist in the font.

fixes #231
@alerque alerque mentioned this issue Mar 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't panic on missing glyph in virtual_font linebender/runebender
2 participants
@alerque @cmyr