Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AudioRenderer implementation, with a render queue #159

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

izzytwosheds
Copy link
Contributor

Basic implementation of audio renderer. Doesn't do much yet (no resampling, no mixing), but does couple of important things:

  • has a render queue which queues up audio frames in order, while encoder is busy and cannot accept new frames
  • handles the case when size of decoded buffer is larger than size of encoder's input buffer by sending decoded buffer into encoder in several parts

Not having render queue in existing audio renderer does result in dropped frames which manifests as distorted audio.

@izzytwosheds izzytwosheds merged commit 550aa75 into linkedin:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants