Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing duration target track metadata when adding track to muxer #244

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

izzytwosheds
Copy link
Contributor

On newer versions of Android MediaFormat produced by Encoder might not contain some useful values (such as duration) even if they were passed in. When such MediaFormat is added to MediaTarget it will produce a video with missing useful metadata, as reported in #222

We are fixing this by populating missing duration and language metadata from source MediaFormat in encoder output MediaFormat before adding a track in MediaTarget.

Assertions are added in unit tests for new logic.

@izzytwosheds izzytwosheds merged commit c08fcbb into linkedin:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants