[Coral-Trino] Revert PR#434 - Do not increment substr starting index

[aastha25]

Previously a PR - PR#434 added a transformation in Coral-Trino to always increment the starting index for 'substr' operator by 1 based on the issue filed #433 which assumed that hive support 0 based indexing for this operator & Trino only supports 1 based indexing.

However, based on recent explorations, it seems that Trino does supports only 1 based indexing. However, hive also supports 1 based indexing and considers 0 to be 1:

hive > create view test_substr0 as select substring('123', 0, 2) as a from t1;
hive > create view test_substr1 as select substring('123', 1, 2) as a from t1;

hive > select * from test_substr0;
OK
12
Time taken: 0.245 seconds, Fetched: 1 row(s)
hive > select * from test_substr1;
OK
12
Time taken: 0.191 seconds, Fetched: 1 row(s)

Hence, PR#434 needs to be reverted. A follow up PR will modify the logic of PR#434 to only update the index when the index is 0.

What changes are proposed in this pull request, and why are they necessary?

How was this patch tested?

./gradlew build