[Coral-Hive] Create new object for ShiftArrayIndexTransformer #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aastha25
reviewed
Mar 4, 2024
coral-hive/src/main/java/com/linkedin/coral/transformers/ShiftArrayIndexTransformer.java
Show resolved
Hide resolved
|
Could you add a test that fails when this patch is not applied? |
@wmoustafa As I mentioned in the description, I couldn't reproduce the issue by UT somehow, still investigating the reason. I have added a TODO item in the comment, can merge it first if it's urgent to unblock the release. |
wmoustafa
approved these changes
Mar 4, 2024
KevinGe00
pushed a commit
to KevinGe00/coral
that referenced
this pull request
Mar 14, 2024
KevinGe00
added a commit
that referenced
this pull request
Mar 14, 2024
…498) Co-authored-by: Jiefan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Prior to this PR,
ShiftArrayIndexTransformermodifies the index of the SqlCall directly, which might transform the same object multiple times if it appears multiple times in SqlNode and generate the wrong index. This PR fixes this issue by creating new object for ShiftArrayIndexTransformer.How was this patch tested?